Repository navigation
[lang] Fix Array.slice with integer bounds - #110
Open
samridh10exe wants to merge 1 commit into
Open
samridh10exe wants to merge 1 commit into
samridh10exe wants to merge 1 commit into
Conversation
Signed-off-by: Samridh <109811970+samridh10exe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Array.slice()failed type checking in cuda.lang for anystartandstop, including integer literals. The shared implementation expects 0D tiles and builds the view with cuTile pointer ops, while cuda.lang uses scalars and its own pointers.Add a cuda.lang implementation that builds the view with
PointerOffsetandArray.from_parts, likearray_getitem, and keeps the same checks onstartandstop. The new tests intest_slice.pycover constant bounds, runtime bounds on the last axis, and the rejected cases.I couldn't run the GPU tests, since
mlir2cubinis not in the public build. On CPU, the kernels from the new tests fail type checking before this change and lower to IR after it, with the view offset atstart * strideand the axis sizestop - start.closes #101
Checklist