Skip to content

Fix FFT minibatch validation for issue 102 - #109

Open
knowrohit wants to merge 2 commits into
NVIDIA:mainfrom
knowrohit:pr-87
Open

knowrohit wants to merge 2 commits into
NVIDIA:mainfrom
knowrohit:pr-87

Conversation

@knowrohit

Copy link
Copy Markdown

Summary

  • validate that minibatch is a positive integer before modulo arithmetic and kernel launch
  • preserve the corrected per-block FFT geometry using BS=minibatch and grid_x=Batch // minibatch
  • add CUDA regression coverage for valid and invalid minibatch values

Validation

  • Managed CUDA checks passed for valid minibatches 1 and 2, including shape, dtype, and numerical equality with torch.fft.fft
  • Managed CUDA checks passed for invalid minibatches 0, -1, and 3
  • Baseline reproduced ZeroDivisionError for minibatch=0; the repaired equivalent command passes when catching the expected ValueError
  • git diff --check passed

The local environment does not have pytest installed, so the focused pytest file could not be run directly.

Fixes #102

AntonOresten and others added 2 commits May 26, 2026 00:27
Signed-off-by: AntonOresten <antonoresten@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: FFT sample launches Batch blocks that each process the full batch

2 participants