Repository navigation
Conversation
(cherry picked from commit 30a6281)
Contributor
github-actions
Bot
added
cuda.bindings
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to The changes are limited to sample documentation links, with no merge-blocking issue established in the supplied context. The reported link check found no remaining errors. ✨ Finishing Touches 💡 1
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 7 broken links reported by the lychee documentation link-checker across
samples/READMEs (moved/renamed upstream pages for libcudacxx, cuda.compute, Nsight Compute occupancy calculator, RAPIDS install docs, and the cuda-samples repo layout).samples/cuda_bindings/3_CUDA_Features/globalToShmemAsyncCopy/README.mdnvidia.github.io/libcudacxx/.../memcpy_async.htmlnvidia.github.io/cccl/unstable/libcudacxx/.../memcpy_async.htmlsamples/cuda_bindings/3_CUDA_Features/globalToShmemAsyncCopy/README.mdnvidia.github.io/libcudacxx/.../pipeline.htmlnvidia.github.io/cccl/unstable/libcudacxx/.../pipeline.htmlsamples/cuda_core/binarySearch/README.mdnvidia.github.io/cccl/python.htmlnvidia.github.io/cccl/unstable/python/compute/index.htmlsamples/cuda_core/cudaComputeLambdas/README.mdnvidia.github.io/cccl/python.htmlnvidia.github.io/cccl/unstable/python/compute/index.htmlsamples/cuda_core/launchConfigTuning/README.mddocs.nvidia.com/cuda/cuda-occupancy-calculator/docs.nvidia.com/nsight-compute/.../occupancy-calculatorsamples/cuda_core/pageRank/README.mdrapids.ai/start.htmldocs.nvidia.com/datascience/install/samples/cuda_core/simplePrint/README.mdcuda-samples/.../Samples/0_Introduction/simplePrintfcuda-samples/.../cpp/0_Introduction/simplePrintfsamples/cuda_core/tmaTensorMap/README.mdnvidia.github.io/cccl/libcudacxx/.../barrier.htmlnvidia.github.io/cccl/unstable/libcudacxx/.../barrier.htmlVerification
Ran
lychee(v0.24.2, matching the pinned pre-commit hook) against all 7 touched files before and after:[404] Rejected status code: 404 Not Founderrors across the 7 files.Notes
rwgk/maint/lychee-pr-nightlybranch (draft ci: complete pre-commit.ci replacement and cache Lychee checks #2993), since that branch bundles a much larger CI/lychee workflow overhaul that isn't ready to merge yet. Pulling just the link fixes out letsmainstop reporting these 7 real errors without waiting on the full CI rework.lycheepre-commit hook currently also flags 7 different, pre-existing errors —503 Service Unavailableongithub.com/NVIDIA/cuda-python/blob/...links (CONTRIBUTING.md andtest_memory_ipc.py) — when run without aGITHUB_TOKEN. These are anonymous-rate-limit false positives (CI passes becauselychee-actionis giventoken: ${{ github.token }}); they're not addressed here and aren't caused by this change.