Repository navigation
ci: save mini-CTK cache only on default branch - #3073
aryanputta wants to merge 3 commits into
Conversation
Signed-off-by: Aryan <aryansputta@gmail.com>
Signed-off-by: Aryan <aryansputta@gmail.com>
Signed-off-by: Aryan <aryansputta@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ➖ Normal Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains; the cache-upload change is ready for normal checks. ✨ Finishing Touches 💡 1
Comment |
|
Sorry I didn't update the issue: it turns out, this isn't what we want to do. I created the issue to clearly document the idea for the team, then there were some discussions that took us in another direction. I didn't get to updating the issue accordingly (I didn't think it's a priority). Creating PRs isn't a bottleneck anymore, at all. Discussions around them and reviews usually consume far more time. I don't recommend jumping on infrastructure issues, these tend to require a lot of internal background. |
Change
Issue #3071 reports 18.23 GiB of mini-CTK caches, with 13.37 GiB on PR refs. Saving only on the default branch should reduce that buildup over time; this patch does not delete existing caches.
The save condition is:
Restore behavior and downloads on cache misses are unchanged.
Checks
python3 -m pytest -q ci/tools/tests/test_ctk_cache_save_gate.py(2 passed)ruff check ci/tools/tests/test_ctk_cache_save_gate.pyruff format --check ci/tools/tests/test_ctk_cache_save_gate.pypython3 toolshed/check_spdx.py ci/tools/tests/test_ctk_cache_save_gate.py.github/actions/fetch_ctk/action.ymlgit diff --check