ci: temporarily pause Pixi lockfile maintenance by jpascucci-nv · Pull Request #3065 · NVIDIA/cuda-python

jpascucci-nv · 2026-10-09T17:18:43Z

[no-ci]

Description

Temporarily suspend Pixi lockfile freshness enforcement and automated refreshes until a released Pixi fix is verified against #7215, #7000, and repeated byte-stable update/lock/check cycles across all six workspaces.

Preserve the existing freshness workflow and check names, run on every PR without path filters, and succeed with a warning and summary explicitly reporting the suspension. Remove the refresh schedule; manual dispatch emits the same notice without installing Pixi, solving, modifying lockfiles, pushing, or creating PRs.

Remove the temporary source-pruning detector and its tests, and drop this PR's manifest-change attribution. Preserve the original classifier tooling, actual build/test jobs, PIXI_FROZEN=true, the pinned Pixi version, and committed lockfiles. Declare pyyaml==6.0.3 for CI-tool workflow tests. Document the manual review and validation required for dependency changes during the pause, and the criteria for restoring strict checks, scheduled refreshes, and PIXI_LOCKED=true.

Validation

Complete CI-tool suite: 105 tests and 36 subtests passed in the locked Pixi environment.
Pre-commit passed on all changed files, including secret scanning and Actions linting; used the CI skips for Lychee and the local hook-install reminder.
Replacement tests cover exact check names, unfiltered PR triggering, manual-only refresh dispatch, both suspension notices, absence of external tool/repository write paths, declared dependencies, and frozen source-build preservation.
Verified the Pixi version pin and all six lockfiles are unchanged.

Checklist

New or existing tests cover these changes.
The documentation is up to date with these changes.

Pixi freshness check was giving the wrong error when the .toml file was changed but the .lock file wasn't checked in.

coderabbitai · 2026-10-09T17:21:18Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3a661591-b0e4-4173-bc01-431ee26cd81d

📥 Commits

Reviewing files that changed from the base of the PR and between 0ba120d and 286dc85.

📒 Files selected for processing (8)

.github/workflows/ci-nightly.yml
.github/workflows/ci-pixi-lockfile-freshness-check.yml
.github/workflows/ci-pixi-lockfile-refresh.yml
.github/workflows/ci-pixi-source-test.yml
ci/README.md
ci/tools/check_pixi_samples_source_pruning.py
ci/tools/tests/test_check_pixi_samples_source_pruning.py
ci/tools/tests/test_pixi_lockfile_freshness_workflow.py

💤 Files with no reviewable changes (2)

ci/tools/tests/test_check_pixi_samples_source_pruning.py
ci/tools/check_pixi_samples_source_pruning.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

CI Changes
- Pixi lockfile freshness checks now report a warning and succeed without verifying manifest and lockfile consistency. Automated lockfile refreshes are paused; the refresh workflow can still be run manually to report the suspension.
- Source builds and tests continue using committed lockfiles in frozen mode. Dependency changes require manual manifest and lockfile validation.
- Nightly CI now installs an additional tool for its checks.

Walkthrough

The Pixi lockfile freshness and refresh workflows no longer check or update lockfiles. They report that these actions are suspended. CI documentation and tests describe and verify the paused behavior.

Changes

Pixi Lockfile Maintenance Pause

Layer / File(s)	Summary
Suspend freshness and refresh workflows `.github/workflows/ci-pixi-lockfile-freshness-check.yml`, `.github/workflows/ci-pixi-lockfile-refresh.yml`, `.github/workflows/ci-pixi-source-test.yml`, `ci/tools/tests/test_pixi_lockfile_freshness_workflow.py`, `.github/workflows/ci-nightly.yml`	The freshness workflow now reports that lockfile freshness was not checked. The refresh workflow is manual-only and reports that refreshes are suspended. Source tests retain `PIXI_FROZEN=true`. Tests verify the workflow triggers, notices, and frozen-mode settings. Nightly CI installs the PyYAML version required by the tests.
Update pause guidance and remove the samples exception `ci/tools/check_pixi_samples_source_pruning.py`, `ci/tools/tests/test_check_pixi_samples_source_pruning.py`, `ci/README.md`	The CI documentation describes the repository-wide pause and the conditions for restoring strict checks and scheduled refreshes. The samples-specific lockfile detector and its tests are removed.

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to 286dc

Pixi lockfile freshness enforcement and automated refreshes are paused on purpose. The pause is documented, and source builds and tests still use the committed lockfiles in frozen mode. No concrete defect remains, so this is ready to merge.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-09T17:36:54Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

rwgk · 2026-10-09T17:45:00Z

Two findings, reviewed at 0ba120d:

P2: The new message is still misleading for ci: complete pre-commit.ci replacement and cache Lychee checks #2993. The new classification rule labels any own-manifest edit with an unchanged stale lockfile “PR-induced”—even when base and PR reproduce exactly the same known Pixi defect. Your task-only edit therefore gets instructions to regenerate and commit a lockfile that Pixi cannot stabilize. The new test explicitly expects this outcome. This changes the instructions; it doesn’t provide a valid repair.
P3: The new tests introduce an undeclared dependency. They import PyYAML, but nightly CI installs only pytest. It currently depends on incidental runner packages. Declare PyYAML if these tests remain.

BUT

Could you please expand this PR into a deliberate temporary pause? Keep real source builds/tests running, but pause freshness enforcement and automated refreshes until a released fix is verified.

Agent-facing instructions generated by my agent, based on my preference to deliberately pause freshness enforcement

Make the pause and cleanup together in ci: temporarily pause Pixi lockfile maintenance #3065. Do not fully revert ci: work around Pixi samples-source lockfile oscillation #3059 or merge separate revert PRs.
Freshness: preserve workflow name CI: pixi lockfile freshness check and job name pixi lock --check (all workspaces). Replace active steps with a successful notice: warning annotation plus job summary explicitly saying enforcement is temporarily suspended, not that freshness passed. Ensure every PR emits the existing check context; remove PR path filters while paused. Do not install/run Pixi, classify staleness, or look up refresh PRs. No branch-protection changes.
Refresh: remove the schedule. Retain the workflow and manual dispatch, but make dispatch emit the same suspension notice and perform no refresh, push, or PR creation.
Cleanup: remove the #7215 detector, its tests, and its special-case handling from both workflows. Drop ci: temporarily pause Pixi lockfile maintenance #3065's new manifest-change attribution and corresponding tests; do not add another exception, label, or mode switch. Preserve unrelated tooling/tests.
Preserve PIXI_FROZEN=true in source-build CI and all actual build/test jobs. Keep the pinned Pixi version and committed lockfiles unchanged. Update comments that still claim freshness is enforced.
Document the pause and tradeoff in ci/README.md: manifest/lock consistency is not automatically enforced; necessary dependency changes require manual review and validation. Link Pixi #7215 and #7000. Re-enable only after a released Pixi passes both reproducers and repeated byte-stable update/lock/check cycles across all six workspaces. Then restore strict checks and PIXI_LOCKED=true.
Validate exact check names, PR triggering, both suspension notices, absence of solver/write paths, and preservation of frozen source builds. Run CI-tool tests and pre-commit; explicitly declare any dependencies introduced by replacement tests.

copy-pr-bot · 2026-10-09T17:45:16Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

rwgk · 2026-10-09T17:59:39Z

Before undrafting, I’d add [no-ci] to the PR description, provided package code, manifests, lockfiles, and build behavior remain unchanged. I see little value in running the full CUDA/GPU matrix for that scope.

We should still require:

Pre-commit/workflow lint and CI-tool tests.
An actual successful run of the freshness suspension job.
Validation that refresh dispatch is visibly paused and cannot write anything.
CPU source-build smoke if its workflow is touched.

copy-pr-bot · 2026-10-09T18:06:26Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

jpascucci-nv · 2026-10-09T18:08:43Z

/ok to test 286dc85

jpascucci-nv · 2026-10-09T18:10:49Z

pixi lockfile refresh suspended - https://github.com/NVIDIA/cuda-python/actions/runs/37970968020/job/113957173228?pr=3065
The [no-ci] got knocked off of the pr description.

jpascucci-nv · 2026-10-09T18:15:33Z

precommit.ci https://results.pre-commit.ci/run/github/381173759/1791569185.Wcr-ooVPTUqANN690ooSgA
Precommit linux: https://github.com/NVIDIA/cuda-python/actions/runs/37970968046/job/113957173233?pr=3065
Precommit windows: https://github.com/NVIDIA/cuda-python/actions/runs/37970968046/job/113957173550?pr=3065

jpascucci-nv · 2026-10-09T18:17:01Z

Lockfile refresh schedule removed.

rwgk

Thanks @jpascucci-nv!

codex GPT-6.1-Sol ultra

No critical findings—I’d approve #3065 at 286dc85. Both earlier findings are addressed.

Freshness preserves the existing check name and explicitly reports suspension; its actual CI run passed.
Refresh scheduling is removed; manual dispatch cannot solve, change lockfiles, push, or create PRs.
PIXI_FROZEN=true and actual build/test behavior remain unchanged.
The Pixi pin and all six lockfiles are untouched; re-enablement criteria are documented.

Removed preview folders for the following PRs: - PR #3024 - PR #3059 - PR #3062 - PR #3063 - PR #3065 - PR #3066 - PR #3067

Identify when pixi toml file has updated relative to lock file

0ba120d

Pixi freshness check was giving the wrong error when the .toml file was changed but the .lock file wasn't checked in.

jpascucci-nv added this to the cuda.bindings 13.5.0 & 12.9.10 milestone Oct 9, 2026

jpascucci-nv requested a review from rwgk October 9, 2026 17:18

jpascucci-nv self-assigned this Oct 9, 2026

jpascucci-nv added the CI/CD CI/CD infrastructure label Oct 9, 2026

rwgk marked this pull request as draft October 9, 2026 17:45

rwgk mentioned this pull request Oct 9, 2026

chore: refresh pixi lockfiles #3064

Closed

rwgk mentioned this pull request Oct 9, 2026

ci: complete pre-commit.ci replacement and cache Lychee checks #2993

Draft

ci: temporarily pause Pixi lockfile maintenance

286dc85

jpascucci-nv changed the title ~~Identify when pixi toml file has updated relative to lock file~~ ci: temporarily pause Pixi lockfile maintenance Oct 9, 2026

jpascucci-nv marked this pull request as ready for review October 9, 2026 22:02

rwgk approved these changes Oct 9, 2026

View reviewed changes

rwgk mentioned this pull request Oct 9, 2026

PyPI override markers make source-package locks stale; PyPI-only refresh drops source records prefix-dev/pixi#7215

Open

rwgk merged commit c7e6f09 into NVIDIA:main Oct 9, 2026
232 of 234 checks passed

github-actions Bot pushed a commit that referenced this pull request Oct 10, 2026

Clean up PR preview folders for 7 closed/merged PRs

a485805

Removed preview folders for the following PRs: - PR #3024 - PR #3059 - PR #3062 - PR #3063 - PR #3065 - PR #3066 - PR #3067

leofang mentioned this pull request Oct 12, 2026

ci: drop Python 3.10 and promote python.supported to ci/versions.yml #3080

Draft

Navigation Menu

Repository navigation

ci: temporarily pause Pixi lockfile maintenance - #3065

ci: temporarily pause Pixi lockfile maintenance#3065
rwgk merged 2 commits into
NVIDIA:mainfrom
jpascucci-nv:not-detecting-pixi-toml-change

jpascucci-nv commented Oct 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

github-actions Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

rwgk commented Oct 9, 2026

Uh oh!

copy-pr-bot Bot commented Oct 9, 2026

Uh oh!

rwgk commented Oct 9, 2026

Uh oh!

copy-pr-bot Bot commented Oct 9, 2026

Uh oh!

jpascucci-nv commented Oct 9, 2026

Uh oh!

jpascucci-nv commented Oct 9, 2026

Uh oh!

jpascucci-nv commented Oct 9, 2026

Uh oh!

jpascucci-nv commented Oct 9, 2026

Uh oh!

rwgk left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jpascucci-nv commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Validation

Checklist

Uh oh!

coderabbitai Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

github-actions Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rwgk commented Oct 9, 2026

Agent-facing instructions generated by my agent, based on my preference to deliberately pause freshness enforcement

Uh oh!

copy-pr-bot Bot commented Oct 9, 2026

Uh oh!

rwgk commented Oct 9, 2026

Uh oh!

copy-pr-bot Bot commented Oct 9, 2026

Uh oh!

jpascucci-nv commented Oct 9, 2026

Uh oh!

jpascucci-nv commented Oct 9, 2026

Uh oh!

jpascucci-nv commented Oct 9, 2026

Uh oh!

jpascucci-nv commented Oct 9, 2026

Uh oh!

rwgk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpascucci-nv commented Oct 9, 2026 •

edited

Loading

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

github-actions Bot commented Oct 9, 2026 •

edited

Loading

rwgk left a comment •

edited

Loading