Repository navigation
Work around pixi lockfile oscillation in lockfile refresh as well. - #3062
Conversation
refs NVIDIA#2850, pr 3059 Add the oscillation check to the refresh path so refresh still works.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe refresh workflow skips a failed ChangesPixi lockfile refresh
Priority: ➖ Normal Change: Bug fix Merge Risk: ⚪ Minimal · up to The refresh workaround appears ready to merge after normal checks. Only the recognized cuda_core lockfile defect is skipped; other failures still stop the refresh.
Comment |
|
rwgk
left a comment
There was a problem hiding this comment.
codex GPT-6.1-Sol ultra:
No blocking findings in PR #3062; I’d approve it.
The important distinction: this makes refresh usable by postponing all cuda_core updates, not by repairing its lockfile. The restore-and-skip branch recognizes the exact defect, restores the pre-update lock, and leaves every other failure fatal. That is a reasonable temporary policy.
Validation:
- Jason’s run exercised the exception and created PR #3063, changing exactly the other five lockfiles.
- All 30 detector tests and 11 executable shell-path checks passed.
- The generated refresh remains compatible with #3059’s freshness exception.
Only non-blocking gap: the new workflow branches lack committed regression tests; our temporary diagnostic harness covers them.
Description
refs pr #3059
Lockfile oscillation is blocking refresh.
Checklist