Repository navigation
ci: drop obsolete ACTIONS_CACHE_URL and ACTIONS_RUNTIME_URL from sccache setup - #3024
Conversation
Install mozilla/sccache v0.18.0 (checksum-verified) in build-wheel.yml instead of the rapidsai fork, and pin the same version in test-sdist-linux.yml. Remove ACTIONS_CACHE_URL and ACTIONS_RUNTIME_URL, which sccache's GHA v2 cache backend does not read, and drop the now-redundant github-script step in test-sdist-linux.yml.
…IONS_ vars Install sccache with mozilla-actions/sccache-action (pinned to v0.18.0) in build-wheel.yml and test-sdist-linux.yml instead of the rapidsai fork, and remove the custom install and github-script steps. Drop ACTIONS_CACHE_URL and ACTIONS_RUNTIME_URL, which the GHA v2 cache backend does not read.
|
/ok to test 235faa3 |
|
|
@juenglin Yeah, let me know if you have any issues. Mozilla's fork isn't sound for caching CUDA files, and ours has a number of other major improvements (like sharing the preprocessor cache). Also, it's about to get an order of magnitude faster than Mozilla's for caching all compilation types (and will be able to cache non-compilation steps, like linking, too). |
…vars Restore the rapidsai/sccache install and the github-script step in build-wheel.yml instead of using mozilla-actions/sccache-action. The CUDA C++/Python teams want to stay on the RAPIDS fork. Only ACTIONS_CACHE_URL and ACTIONS_RUNTIME_URL stay removed, from both the github-script export and the CIBW_ENVIRONMENT_LINUX forwarding. sccache's GHA v2 backend reads only ACTIONS_RESULTS_URL and ACTIONS_RUNTIME_TOKEN.
|
/ok to test 158541f |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe wheel workflow no longer exports or passes ChangesWorkflow cache configuration
Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk was identified in these workflow changes.
Comment |
Description
Remove the obsolete
ACTIONS_CACHE_URLandACTIONS_RUNTIME_URLvariables from the sccache setup.sccache's GitHub Actions cache backend (OpenDAL
ghac) never readsACTIONS_RUNTIME_URL. It readsACTIONS_CACHE_URLonly for the v1 cache service. WithACTIONS_CACHE_SERVICE_V2set, as it is here, onlyACTIONS_RESULTS_URLandACTIONS_RUNTIME_TOKENare used, which matches sccache'sdocs/GHA.md.Changes
build-wheel.yml: stop exporting and forwardingACTIONS_CACHE_URLandACTIONS_RUNTIME_URLinto the cibuildwheel container. Therapidsai/sccacheinstall is unchanged.ACTIONS_CACHE_SERVICE_V2,ACTIONS_RESULTS_URLandACTIONS_RUNTIME_TOKENare still forwarded.test-sdist-linux.yml: remove thegithub-scriptstep that only re-exported the two obsolete variables, and pinmozilla-actions/sccache-actionto sccachev0.18.0(the base of therapidsaifork) instead of tracking the latest release.Checklist