Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,33 @@ updates:
patterns: ["*"]
update-types: ["major", "minor", "patch"]

labels: [CI/CD, dependencies]

# Group monthly hook revision updates, preserving SHA pins and frozen comments.
- package-ecosystem: pre-commit
directory: /
schedule:
interval: "monthly"
time: "09:00"
timezone: "America/Los_Angeles"

open-pull-requests-limit: 1

# Match hook repositories, leaving additional_dependencies pins unchanged.
allow:
- dependency-name: "https://github.com/*"
# Lychee's hook revision, LYCHEE_VERSION argument, and CI binary pin must
# be upgraded together in a coordinated manual update.
ignore:
- dependency-name: "https://github.com/lycheeverse/lychee"

groups:
pre-commit-monthly:
applies-to: version-updates
patterns: ["*"]

labels: [CI/CD, dependencies]

# GitHub Actions updates targeting the 12.9.x branch
- package-ecosystem: github-actions
directory: /
Expand All @@ -38,3 +65,5 @@ updates:
applies-to: version-updates
patterns: ["*"]
update-types: ["major", "minor", "patch"]

labels: [CI/CD, dependencies]
71 changes: 71 additions & 0 deletions .github/workflows/pre-commit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# SPDX-License-Identifier: Apache-2.0

name: "CI: pre-commit"

on:
pull_request:
types: [opened, reopened, synchronize]
push:
# PR events cover draft and fork PRs without also checking copy-pr-bot's
# pull-request/N mirrors. Only main needs a push check.
branches:
- "main"
workflow_dispatch: {}

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
cancel-in-progress: true

permissions:
contents: read

defaults:
run:
shell: bash --noprofile --norc -xeuo pipefail {0}

jobs:
pre-commit:
name: Pre-commit (${{ matrix.name }})
runs-on: ${{ matrix.os }}
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
include:
- name: Linux
os: ubuntu-latest
- name: Windows
os: windows-latest
env:
# Link checks have their own Linux workflow. The installation reminder
# is for developer machines; CI does not install a Git commit hook.
SKIP: lychee,check-precommit-installed
steps:
- name: Checkout repository
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 1
persist-credentials: false

- name: Set up Python
id: python
uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0
with:
python-version: '3.14'

- name: Set pre-commit cache location
run: echo "PRE_COMMIT_HOME=${RUNNER_TEMP}/pre-commit" >> "${GITHUB_ENV}"

- name: Cache pre-commit environments
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.PRE_COMMIT_HOME }}
key: pre-commit-${{ runner.os }}-${{ steps.python.outputs.python-version }}-${{ hashFiles('.pre-commit-config.yaml') }}

- name: Install pre-commit
run: python -m pip install --upgrade pip pre-commit

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason to always upgrade pip? I think in this clean environment we always get the latest version anyway. (Maybe the caching means it might be stale)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep the upgrade: it is very quick when pip is already current and removes a doubt.

Rationale:

I asked codex to look a little deeper. It found:

A clean environment doesn't guarantee that it will always be a no-op. With our inputs, setup-python selects a Python installation and doesn't automatically upgrade pip. Python's bundled pip can lag the separately released version on PyPI. The pre-commit cache contains hook environments, rather than the host's pip, so that cache isn't the explanation.

codex also explained:

The original workflow kept the pip upgrade from the existing Windows job so that pre-commit is installed with the current pip. There's no demonstrated need for a newer pip today. In the earlier validation run, both Linux and Windows already had pip 26.2.1, so the upgrade was a no-op.


- name: Run pre-commit
run: pre-commit run --all-files --show-diff-on-failure
Loading