Repository navigation
Conversation
leofang
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I don't think we want to burn resources this much for pre-release software on a per-PR basis. Could you keep 3.15/3.15t to nightly-standard rows only?
Removed configurations for Python version 3.15 and 3.15t from the test matrix.
| host = [ | ||
| # TODO: remove the Python 3.15 guard once 3.15 is officially supported | ||
| "nvidia-cutlass; python_version < '3.15'", | ||
| "nvidia-cutlass", |
There was a problem hiding this comment.
Did you check that cutlass already has 3.15 support?
Co-authored-by: Leo Fang <leo80042@gmail.com>
Added new configurations for Python 3.15 and 3.15t with CUDA 13.3.0 for AMD64 and ARM64 architectures.
|
@leofang, please review |
📝 Summary
Priority: ➖ Normal Change: Feature Merge Risk: 🔵 Low · up to The new amd64 Python 3.15 configurations are not exercised by nightly-standard, leaving those combinations without the intended CI coverage. The arm64 entries are covered; add an amd64 job or remove the unused rows. ✨ Finishing Touches 💡 1
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: NVIDIA/cuda-python/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
c5d5f34c-1a63-404f-b6a6-5133a9df1594
📒 Files selected for processing (2)
ci/test-matrix.ymlci/tools/download-wheels
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
| - { ARCH: 'amd64', PY_VER: '3.15', CUDA_VER: '13.4.2', LOCAL_CTK: '0', GPU: 'a100', GPU_COUNT: '1', DRIVER: 'latest', DRIVER_MODE: 'MCDM', ENV: { MODE: 'nightly-standard' } } | ||
| - { ARCH: 'amd64', PY_VER: '3.15t', CUDA_VER: '13.4.2', LOCAL_CTK: '0', GPU: 'a100', GPU_COUNT: '1', DRIVER: 'latest', DRIVER_MODE: 'MCDM', ENV: { MODE: 'nightly-standard' } } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
suggestion: Route the amd64 entries to a nightly-standard job.
ci-nightly.yml runs nightly-standard only for linux-aarch64. The shared Linux workflow filters matrix entries by the requested architecture. These amd64 rows are therefore never selected and add no amd64 Python 3.15 or 3.15t test coverage. Add a linux-64 nightly-standard job or remove the unused rows. (raw.githubusercontent.com)
As per path instructions: “focus on matrix correctness” and “targeted build and test behavior.”
Source: Path instructions
clin1234
left a comment
There was a problem hiding this comment.
Looks good
Commented in CodeRabbit Change Stack
Description
closes #2163
Checklist