Skip to content

fix(ci): skip maintainer approval in merge queue - #4496

Merged
purp merged 2 commits into
NVIDIA:mainfrom
purp:codex/fix-maintainer-check-queue/purp
Oct 13, 2026
Merged

purp merged 2 commits into
NVIDIA:mainfrom
purp:codex/fix-maintainer-check-queue/purp

Conversation

@purp

@purp purp commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Skip maintainer approval evaluation for merge-group checks while preserving the existing check name and trigger so GitHub can satisfy the queue's required check. Use the event context to run the approval job only for open PRs; review changes after queue admission do not cause a merge-group approval reevaluation.

Related Issue

No issue, as requested by the maintainer.

Changes

  • Skip the job for merge-group events and closed PRs using the built-in GitHub context.
  • Remove the obsolete merge-queue ref parsing. The existing review lookup and approval helper remain unchanged.

Testing

  • git diff --check passes.
  • Extracted workflow shell syntax passes bash -n.
  • Actionlint and the pytest suite were unavailable because dependency downloads were blocked in the environment. No persistent tests added; no runtime changes requiring E2E tests.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs: not applicable.

Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp
purp requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners October 13, 2026 17:33
@purp
purp marked this pull request as draft October 13, 2026 17:37
@copy-pr-bot

copy-pr-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp
purp marked this pull request as ready for review October 13, 2026 19:04
@purp
purp enabled auto-merge October 13, 2026 19:04
@purp
purp added this pull request to the merge queue Oct 13, 2026
Merged via the queue into NVIDIA:main with commit 5a7728c Oct 13, 2026
79 checks passed
@purp
purp deleted the codex/fix-maintainer-check-queue/purp branch October 13, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants