Repository navigation
fix(core): retry transiently busy e2fsprogs probes - #4315
Conversation
Signed-off-by: Gordon Sim <gsim@redhat.com>
6639835
left a comment
There was a problem hiding this comment.
Reviewed bounded executable-busy retry and cancellation/cleanup at 29c9c53. Only ExecutableFileBusy retries for at most twenty 50ms delays; other errors fail immediately. Each delay prioritizes cancellation, and success retains timeout/process-group cleanup/reap. Linux regression releases a writer after 100ms. No actionable issue found. Rust builds/Linux process tests were not run.
|
Label |
|
/ok to test 29c9c53 |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The bounded executable-busy retry has no blocking review findings. It retries only the transient Linux error, keeps cancellation responsive, and preserves process cleanup; the added Linux regression test covers recovery after the executable writer closes.
Branch Checks, Helm Lint, and the standard E2E suite are queued or running for the current head after applying test:e2e and posting /ok to test. Trivy Changes is still awaiting workflow approval, and sandbox policy prevents Gator from approving that run.
Action required: A maintainer must approve the current-head Trivy Changes run, or the operator must allow the scoped workflow-approval endpoint.
Blocking findings: None.
Carried findings: None.
Gator metadata
- Validation: Focused VM host-tool preflight bug fix with reproduction and acceptance criteria in #4314; no duplicate found.
- Docs: No update needed for an internal transient-error retry with unchanged commands, configuration, and diagnostics.
- Checks: DCO and vouch passed; Branch Checks and Helm Lint dispatched; Trivy Changes requires workflow approval.
- E2E:
test:e2eapplied; current-head Branch E2E Checks run 38296984577 dispatched; no GPU or Windows label needed. - Head SHA:
29c9c53c22f505deca7478a7c06b9c73bfc9006c - Base SHA:
e406c2befbe65501409026d49259602669f7246a - Merge base SHA:
e406c2befbe65501409026d49259602669f7246a - Patch ID:
1877b276d62dc6ae7682e56e98644d41b87fca0b - Gator payload:
12 - Review mode:
initial - Previous reviewed SHA:
none - Review budget exhausted:
no - Maintainer decision required:
no - Next state:
gator:blocked - Blocked reason:
workflow_approval_required
Monitoring CompleteMonitoring is complete because this PR has merged. The remaining Gator metadata
|
Summary
Prevent e2fsprogs preflight checks from failing when Linux temporarily reports a newly installed executable as busy.
Related Issue
Closes #4314
Changes
ExecutableFileBusyerrors for up to one second when starting an e2fsprogs version probe.Testing
Checklist