Skip to content

FIX critical vulnerability in gitpython - #392

Merged
hatwell merged 1 commit into
masterfrom
fix/gitpython-vulnerabilities
Sep 14, 2026
Merged

hatwell merged 1 commit into
masterfrom
fix/gitpython-vulnerabilities

Conversation

@hatwell

@hatwell hatwell commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-XXXX


📄 Description/Summary of Changes

  • Updated dependency gitpython to ^3.1.62 to resolve critical vulnerability.

🧪 Developer Testing Carried Out


📋 PR Principles

  • Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review.
  • Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket.
  • Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made.
  • Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices.
  • Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed.
  • Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment.

🏷️ Naming Conventions Reminder

Please ensure the following naming conventions are followed:

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>

Copilot AI lite review requested due to automatic review settings September 14, 2026 10:41
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Regenerate and commit poetry.lock to match the dependency change.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates GitPython to version ^3.1.62 to address a critical vulnerability.

Changes:

  • Raises the GitPython dependency constraint.
  • Requires regeneration and commitment of the Poetry lockfile.
File summaries
File Reviewed changes
pyproject.toml Updates GitPython; poetry.lock has a stale content hash and must be regenerated.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pyproject.toml
jsonpath-rw = "^1.4.0"
semver = "^3.0.2"
gitpython = "^3.1.55"
gitpython = "^3.1.62"
@hatwell
hatwell merged commit 54162df into master Sep 14, 2026
22 checks passed
@hatwell
hatwell deleted the fix/gitpython-vulnerabilities branch September 14, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants