Skip to content

CCM-24223: Add role policy attachment dependency for lambda - #330

Merged
sidnhs merged 2 commits into
mainfrom
feature/CCM-24223_fix
Oct 12, 2026
Merged

sidnhs merged 2 commits into
mainfrom
feature/CCM-24223_fix

Conversation

@sidnhs

@sidnhs sidnhs commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Description

We were getting race conditions with the aurora bootstrap lambda where the IAM role policy for the execution role was getting destroyed before teh lambda, leading to a series of half-destroyed PR envs e.g.:
https://github.com/NHSDigital/nhs-notify-internal/actions/runs/37965655660/job/113939779017

https://github.com/NHSDigital/nhs-notify-internal/actions/runs/38232045638/job/114754228314 - this seems to destroy cleanly

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@sidnhs
sidnhs requested a review from a team as a code owner October 12, 2026 09:59
@sidnhs sidnhs added the skip-dependencies-check skip-dependencies-check label Oct 12, 2026
@sidnhs
sidnhs merged commit 969ef73 into main Oct 12, 2026
30 checks passed
@sidnhs
sidnhs deleted the feature/CCM-24223_fix branch October 12, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-dependencies-check skip-dependencies-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants