Repository navigation
Allowing passing in multiple domains using the -d switch - #322
Merged
Merged
Conversation
vigneshmsft
force-pushed
the
renew-fd-cert-script
branch
3 times, most recently
from
October 14, 2026 09:23
98e11ab to
567db6c
Compare
vigneshmsft
force-pushed
the
renew-fd-cert-script
branch
from
October 14, 2026 13:49
567db6c to
637fbb2
Compare
Contributor
|
so I would change the PR comment |
vigneshmsft
force-pushed
the
renew-fd-cert-script
branch
from
October 14, 2026 13:53
637fbb2 to
45fd790
Compare
vigneshmsft
changed the title
Suppport passing in multiple domains using the -d switch. Move SSL renewal logic to inside process_domain function which can be reused for each domain passed.
vigneshmsft
force-pushed
the
renew-fd-cert-script
branch
from
October 14, 2026 13:58
45fd790 to
31785ec
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allowing passing in multiple domains using the -d switch.
Context
Move SSL renewal logic to inside process_domain function, will be useful for products like Rubie which have multiple apex domains under a single subscription that can be renewed in one job run instead of a having a job for each domain under the same subscription.
Tested script in a pipeline run under
dtos-manage-breast-screeningType of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.