Skip to content

feat: speed up training, remove pad token requirement - #390

Merged
stephantul merged 3 commits into
mainfrom
fast-train
Oct 7, 2026
Merged

stephantul merged 3 commits into
mainfrom
fast-train

Conversation

@stephantul

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
model2vec/train/base.py 100.00% <100.00%> (+0.43%) ⬆️
model2vec/train/classifier.py 100.00% <ø> (ø)
model2vec/train/dataset.py 99.46% <100.00%> (+0.07%) ⬆️
model2vec/train/pairs.py 100.00% <100.00%> (ø)
model2vec/train/similarity.py 100.00% <ø> (ø)
model2vec/train/trainer.py 99.12% <100.00%> (ø)
model2vec/train/utils.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Removes padding token requirement from training pipeline.

The PR is not ready to merge because fitting a frozen, headless model without supplied token weights now fails.

Reviews (1) · Last reviewed commit: "feat: speed up training"

Comment thread model2vec/train/base.py
@stephantul
stephantul requested a review from Pringled October 7, 2026 06:05

@Pringled Pringled left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM

@stephantul
stephantul merged commit 066f91a into main Oct 7, 2026
11 checks passed
@stephantul
stephantul deleted the fast-train branch October 7, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants