Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
mmx speech transcribe --streamexits successfully when the response ends beforefinish=true. It only warns on stderr; JSON mode also prints the partial transcript in the normal success shape. A script checking the exit status can therefore accept an incomplete transcript as complete.The transcription API specifies
finish=trueas the terminating event. The SDK already rejects an early end; this fixes the CLI path. Open streaming fixes #263 and #266 cover text generation and speech synthesis, not transcription.Fix
Raise
CLIErrorwith exit code 1 after the existing response cleanup if no final event was received. Keep already-streamed text and its trailing newline; do not emit a successful JSON result for an incomplete stream. Completed and non-streaming responses are unchanged. No new dependency or public API.Validation
[DONE], each with text / JSON output. Unchanged production code: 18 passed / 4 failed in the transcription command module. Fixed command, speech SDK and SSE parser: 62 passed.Full-suite validation uses temporary configuration, a process-local no-op URL opener and a validation-only fetch preload rejecting external hosts by default (test-owned mocks may override it). The full Windows OAuth suite was not run because of its existing browser-opening mock issue. No timeouts, assertions or existing skip conditions were relaxed.
Implemented and tested with Codex assistance. Blind reviews are automated, not human approval.
Need help on this PR? Tag
@codesmith-botwith what you need.