Repository navigation
Resume node downloads and lengthen the enrollment token - #732
Merged
Merged
Conversation
SaladDay
force-pushed
the
resume-node-downloads
branch
from
October 15, 2026 13:02
dcca467 to
f07dddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.partialfile; the next attempt or rerun continues from its size, printsResuming <file> at X MiB of Y MiB, and falls back to a full download when the server answers 200 or 416, or when the resumed bytes fail the checksum. Redirects (Core to GitHub) forward only theRangeheader.runtime_node_enrollmentsinsert inruntime_nodes.sqland the generated sqlc file). Web already readsexpires_atfrom Core's response, so the countdown follows; e2e fixtures and docs updated.docs/getting-started/nodes.md(EN + zh,source_hashrefreshed),deploy/node/README.md.Why
Audit-node finding 2 and P2 9: slow links restarted at byte 0 and outlived the 10-minute token. Verified: Core's local artifact serving uses
http.ServeContent(Range supported); GitHub release assets answer206withContent-Rangeafter the 302 (checked with curl).Verification
python3 -m unittest discoverindeploy/node: 148 tests OK (1 skipped). New cases: resume from an earlier partial, resume after a mid-transfer break, server ignoring Range (200, full download), oversize partial dropped, unrelated partial restarted after checksum failure, Range through an HTTPS redirect.go build ./...,go vet ./...,go test ./internal/deployment/...inservices/core: OK.pnpm --filter @oac/web typecheck, vitestnode-enrollment.test.ts: OK.scripts/check-names.py: OK.Skipped
nodes.spec.ts(no browser here; only its 10-minute timings changed to 1 hour), DB-backed Go integration tests, root installer run.Resuming, expiry after >1 h of token age re-registers with a new command and the same partial files.Need help on this PR? Tag
@codesmith-botwith what you need.