Repository navigation
Keep the installer's proxy and clean up node uninstall - #730
Merged
SaladDay merged 2 commits intoOct 15, 2026
Merged
Conversation
SaladDay
force-pushed
the
keep-the-installer-proxy-and-clean-up-node-uninstall
branch
from
October 15, 2026 12:59
7ea7df8 to
87c4d05
Compare
SaladDay
deleted the
keep-the-installer-proxy-and-clean-up-node-uninstall
branch
October 15, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/etc/oac-node/<id>.env(root, 0600) read throughEnvironmentFile=-in the unit. Both spellings,localhost,127.0.0.1,::1appended toNO_PROXY. A rerun replaces the file (andtry-restarts a running service when it changed); a run without an HTTP(S) proxy removes it; uninstall removes it. Credentials never enter the world-readable unit. The child's proxy filter is now the sharedproxy_settings.~/.oac/m/<sha12>, only when itsoac-installation.jsonnames this installation) once Core confirmed the removal, so the created account is released in the same run.--force(Core not asked) keeps the store and prints the exactrm -rfcommand. Account deletion still depends onaccount.jsoncreated. Docker image hint unchanged; the output says deleted vs kept. Thenode_spec.fetchuninstall hint (Lane H) is untouched.source_hashrefreshed): proxy section, Records row, Connection failures row, uninstall paragraph; README rules.Why
audit-node finding 6 (proxy-only hosts) and 9 (uninstall multi-step); decisions.md decision 4. No new flag or setting.
Verification
python3 -m unittesttest_node_proxy, test_node_install, test_node_spec, test_node_readiness, test_node_generations, test_generation_review_regressions, test_distribution, test_node_helper_transfer: passscripts/check-names.py: pass; translations test 1-2 pass, test 3 needs vitepress (fails identically on main here), skipped.Left for live check on mx2 (root)
Install behind a proxy and check the 0600 env file and journal connect; rerun with another proxy; microsandbox uninstall frees ~/.oac/m and the account.
Need help on this PR? Tag
@codesmith-botwith what you need.