Repository navigation
Show the node uninstall command any time - #725
Merged
Merged
Conversation
SaladDay
force-pushed
the
show-the-node-uninstall-command-any-time
branch
2 times, most recently
from
October 15, 2026 13:07
053c28a to
81265c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nodeUninstallCommand, for any time (host removed earlier, retired by a reset, or never registered). The dialog's node name is now optional.deploy/node/node_spec.py, 401 branch offetch): now a runnablesudo python3 <installer path> --uninstall --installation-id <id>.source_hashrefreshed):nodes.mddrops the stale command template and points at Clean up a host; it names the real installation ID sources (unit name,/etc/oac-node/<id>.json, Settings → Service and deployment → Installation details) and the Core-gone command.operations.mdfixes the installation ID paragraph (no file in the deleted volume) and Protocol changes now says to archive Sessions before upgrading, since removal is refused while a node holds sandboxes.Why
audit-node.md finding 3 (uninstall command hard to reach, stale references) and finding 5 docs (upgrade order).
Verification
pnpm --filter @oac/web typecheck: passvitest run enrollment-command.test.ts: 15 passpython3 -m unittest test_node_spec(new test pins the hint): passnode --test website/tests/translations.test.mjs: 3 pass;check-names.py: passSkipped
nodes.spec.ts(new case added) not run locally: no Chrome channel on this host; relies on CI web-acceptance.Need help on this PR? Tag
@codesmith-botwith what you need.