Repository navigation
Pin PostgreSQL by digest and mirror it to GHCR - #723
Merged
Merged
Conversation
SaladDay
force-pushed
the
pin-postgresql-by-digest-and-mirror-it-to-ghcr
branch
2 times, most recently
from
October 15, 2026 12:48
a222acb to
a5e2133
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
deploy/compose/database-image.txtholds the officialpostgres:16-alpine@sha256:721873c3…multi-platform index (16.15-alpine3.24, re-verified against Docker Hub; its amd64 child is1a66d744…, the digest the bundle already pinned).deploy/compose/compose.yamltakes__OAC_DATABASE_IMAGE__;scripts/render-compose.pyexposesDATABASE_PINand renders the release value.scripts/publish-core-release.pycopies that index withdocker buildx imagetools createtoghcr.io/<repo>/postgres:<version>, keeps all platforms and the digest, refuses a tag that names another digest, and the releasecompose.yamlpinsghcr.io/<repo>/postgres@sha256:721873c3….build-core-distribution.shresolves the linux/amd64 child from the pin (no second digest);install-source.pyfills the template token like the other images.ci_plan.pyselects the compose jobs for the new.txt.source_hashrefreshed): every image comes from GHCR, Docker Hub not needed; maintainers describe the pin and the mirroredpostgrescomponent.Why
Audit-core finding 3 and section 7: floating Docker Hub tag, never refreshed on upgrade, two pins, unreachable from some hosts (mx); user decision 2.
Upgrade
oac install --upgradeandinstall.py --upgraderender the new releasecompose.yaml;config --imageslists the new digest, it is pulled from GHCR, anduprecreates the database container on the same named volume. The pin file test and the bundle's PostgreSQL 16 check keep the major version fixed.Verification
deploy/compose/test_compose.py,deploy/test_install_source.py,scripts/publish-core-release.test.py(39),scripts/core-distribution-manifest.test.py,scripts/ci_plan_test.py: pass.scripts/check-names.py: pass.node --test website/tests/translations.test.mjs: 1-2 pass, test 3 skipped (vitepress not installed here).Not run:
compose-smoke.py(needs Docker Hub; CI compose job covers it), a realimagetools createagainst GHCR.Need help on this PR? Tag
@codesmith-botwith what you need.