Repository navigation
Give Core its own health check - #721
Merged
Merged
Conversation
SaladDay
force-pushed
the
give-core-its-own-health-check
branch
3 times, most recently
from
October 15, 2026 12:44
630a53a to
92ea97e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
oac-core healthcheckprobes Core's own/healthzon127.0.0.1;compose.yamlruns it as Core's healthcheck.oac-web healthchecknow probes only Web's own listener.${OAC_PUBLIC_URL:-http://localhost:${OAC_WEB_PORT:-8080}}.scripts/compose-smoke.pyupdated (the smoke now uses a fixed free loopback port and asserts the upgraded default origin follows it).Why
Audit-core 3a, 5(ii), 7: Web's health implied Core's, so after a long Core outage the first rerun /
oac applyfailed on Web's staleunhealthyand only the next succeeded.up --waitnow waits on each service directly. The installer (oac) only runsup --wait, so it needs no change.processconfigonly gets a doc-comment update, sincehealthcheckalso callsLoad.Verification
go vet ./...(core, web): passgo testservices/core/cmd/server, internal/processconfig, services/web: pass (new tests: Core and Web healthcheck probe only their own listener)python3 -m unittest deploy/compose/test_compose.py: pass (new origin cases)scripts/check-names.py: pass; zhsource_hashvalues verifiedSkipped
compose-smoke.py: the host cannot reach gcr.io to build the images; CI's compose job covers it.Need help on this PR? Tag
@codesmith-botwith what you need.