Repository navigation
No Fall enhancements - #6711
Merged
Merged
No Fall enhancements#6711
Conversation
Use the server-synced interaction range for bucket targeting so Reach cannot trigger rejected placements. Keep landing water until acknowledgement and a stable landing, retry rejected predictions, and restore the selected slot after use. Add optional NoGround reset packets and a shared rotation toggle for AirPlace and Place. Keep solid block placement on BlockUtils.
Predict landing surfaces for all Place items while preserving server interaction reach. Keep completed landings and pickup state across delayed acknowledgments so moving away does not suppress recovery.
Sync master with upstream for Minecraft 26.3 while preserving the NoFall enhancements. Use the packet record sequence accessors required by 26.3.
Collaborator
|
One clarification: is the early |
Contributor
Author
|
That comes from the existing Creative mode guard. I can move NoGround before it so it applies in Creative too but it isnt needed as Players in Creative cant get any fall damage. One use is mayby to keep Mace fall height but aside from that its not needed in creative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fix bucket clutches predicted outside the server's reach when Reach is enabled. Predict landing surfaces for all Place items, including horizontal movement, and recheck bucket placement before use.
Improve automatic pickup by aiming inside the source block, retaining recovery state through pickup acknowledgments, and remembering completed landings while waiting for the server. Pickup uses the normal bucket interaction.
Add NoGround with optional reset packets on disable and a shared rotate toggle for AirPlace and Place.
How Has This Been Tested?
./gradlew buildpassed.Checklist