Repository navigation
CH-300 feat: Upgrade Argo to 3.3.10 (to allow self-report progress) - #886
Closed
afonsobspinto wants to merge 4 commits into
Closed
afonsobspinto wants to merge 4 commits into
afonsobspinto wants to merge 4 commits into
Conversation
afonsobspinto
force-pushed
the
feature/CH-300
branch
from
October 23, 2026 19:13
06800e5 to
79155ac
Compare
afonsobspinto
force-pushed
the
feature/CH-300
branch
from
October 23, 2026 19:26
79155ac to
5bea91e
Compare
afonsobspinto
force-pushed
the
feature/CH-300
branch
from
October 23, 2026 21:28
5bea91e to
f654dc7
Compare
afonsobspinto
marked this pull request as ready for review
October 23, 2026 22:09
afonsobspinto
marked this pull request as draft
October 28, 2026 10:25
Member
Author
|
Dropped for #887 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://metacell.atlassian.net/browse/CH-300
Upgrade Argo Workflows from 3.1.15 to 3.3.10, retaining PNS and the existing CloudHarness SDK/API contract. Include a small controller-only upstream backport so self-reported progress reaches Workflow status while long tasks are still running.
Changes
b19870d737a14b21d86f6267642a63dd14e5acd5with the TaskResult create/update event handlers from upstream Argo 3.5.8. The controller reportsv3.3.10-ch.1; no newer controller behavior or executor is adopted.v1for CloudHarness logs. ExistingextraEnventries, including explicit pod-name overrides, remain intact.Miscellaneous changes already included: upgrade the scanner-runner Ubuntu version and fix the pre-existing syntax/formatting failures required for CI.
Why the controller backport is needed
Stock 3.3.10's executor publishes progress to WorkflowTaskResults, but its controller does not enqueue the Workflow when those records change. Long tasks can therefore show stale Workflow progress until another event or the roughly twenty-minute reconciliation. Short tests that finish their pod can hide the problem.
Relying on legacy pod-annotation fallback is insufficient: CloudHarness's workflow account already has broader permissions that allow TaskResult writes. The backport fixes the native path through Argo's existing rate-limited work queue. NeuroGlass and other consumers can keep reading normal Workflow status.
Self-reporting progress
Tasks overwrite
ARGO_PROGRESS_FILEwithcompleted/total, for example:By default the executor reads the file every 3 seconds, publishes changed counters approximately every minute, and the patched controller queues Workflow reconciliation (default delay 10 seconds). Consumers use the existing CloudHarness workflow API. API load and application caching can add delay; this is not a maximum-latency guarantee.
Build/deploy Argo through the normal CloudHarness pipeline so the controller uses the built image. An explicit override to the stock upstream controller removes the backport. No files under
libraries/change.Validation