Repository navigation
docs(gemini-task): Gemini reviews its finished work with a fresh subagent - #12476
Merged
Merged
Conversation
…gent Before the hand-over, Gemini starts one reviewer subagent that sees only Acceptance and the diff, runs the mutation table plus its own breaks, and reports findings; Gemini fixes what holds up and lists every finding under ## Self-review in the PR body. Claude's independent review stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Three unresolved findings in .claude/skills/gemini-task/SKILL.md remain open, and the main gap is that the self-review step skips single-brief tasks even though the PR description and changelog say it runs for any finished task.
3 open issues
What changed in this PR
This PR changes the gemini-task skill so Gemini has its finished work reviewed by a fresh subagent before it hands the work over. Claude's independent Opus review stays in place, because a reviewer of the same model shares the author's blind spots. The skill is Claude's process document for briefs that Gemini works in the owner's interactive agy session.
Changes:
- Adds step 7 to the Gemini section of the skill. Gemini starts a reviewer subagent that sees only the Acceptance section and the diff, and reports findings without committing or pushing.
- Adds a
## Self-reviewsection to the hand-over PR body. Each finding is listed as fixed (with its commit) or declined (with the reason). - Renumbers the hand-over from step 7 to step 8 and updates all references to it. Section 3 now says Claude judges each declined finding.
| File | Description |
|---|---|
| changelog.d/gemini-self-review.md | Adds the changelog fragment for the self-review step. |
| .claude/skills/gemini-task/SKILL.md | Adds the reviewer step, the Self-review section in the PR template, and the renumbered hand-over references. |
Review effort: Lite
…, has a blocker line Copilot review on #12476 (three low findings). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The owner's call after #12470: code quality comes before saving tokens, so Gemini reviews its own finished work before Claude sees it.
gemini-taskskill. Once a task (a single brief or one in packages) or a review round is done and the gates pass, Gemini pushes and starts one fresh subagent as the reviewer, in its own worktree on a detached checkout of the task branch. The reviewer's prompt names only the brief's Constraints and Acceptance and the diff, not Gemini's plan or notes, so it judges the code rather than the intent. It reads the whole diff for defects, runs the mutation table plus two or three breaks of its own, and reports findings withpath:line, severity, and a fix. It commits and pushes nothing. Gemini fixes what holds up, reruns the gates, and pushes. A hand-over on a blocker skips the step.## Self-reviewin the hand-over PR body lists every finding as fixed (with its commit) or declined (with the reason), or as not run after a blocker hand-over. Review-round comments carry the findings too./zweitmeinungrule that a Gemini review never counts as the independent review of Gemini's work.Test plan
uv run python -m tools.changelog check --base origin/main: the fragment is well-formed and the diff passes.grepforsection 2, stepandstep 7across the skills and docs: every reference names the new numbers.🤖 Generated with Claude Code