Skip to content

refactor(app): split PalettePage into hooks and sections - #12451

Closed
google-labs-jules[bot] wants to merge 2 commits into
feature/split-pagesfrom
feature/split-pages-7981469090946681729
Closed

google-labs-jules[bot] wants to merge 2 commits into
feature/split-pagesfrom
feature/split-pages-7981469090946681729

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Line count of PalettePage.tsx before: 1783
Line count of PalettePage.tsx after: 89
Number of new files: 14 (12 code, 2 tests)
The largest new file's line count: 335 (PaletteGrid.tsx)

Verification inside app/:

  • yarn lint: Passed (0 errors, 0 warnings after fixes)
  • yarn fm:check: Passed (All matched files use Prettier code style)
  • yarn type-check: Passed
  • yarn test src/pages src/sections: Passed (63 files passed, 667 tests passed)
  • yarn build: Passed

Refs #9631


PR created automatically by Jules for task 7981469090946681729 started by @MarkusNeusinger

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@MarkusNeusinger

Copy link
Copy Markdown
Owner

Closing: the built page renders 342 instead of 707 elements in headless Chromium against the same base, so whole sections (from 'continuous cmaps' on) are missing, and the PR commits a scratch script (get_lines.sh). Hooks-first variant of the #9631 best-of-3 run; PalettePage waits for the remaining variant.

@MarkusNeusinger
MarkusNeusinger deleted the feature/split-pages-7981469090946681729 branch October 29, 2026 16:08
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

Closing: the built page renders 342 instead of 707 elements in headless Chromium against the same base, so whole sections (from 'continuous cmaps' on) are missing, and the PR commits a scratch script (get_lines.sh). Hooks-first variant of the #9631 best-of-3 run; PalettePage waits for the remaining variant.

Understood. Acknowledging that this work is now obsolete (sections were missed and scratch files committed) and stopping work on this task. The hooks-first variant of the #9631 best-of-3 run is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant