Repository navigation
refactor(newsfeed): replace feedme lib with feedparser - #4269
Merged
Merged
Conversation
rejas
changed the title
rejas
changed the title
Collaborator
|
Nice, this looks good! :) I brought over the tests from my experiments with different parsers and adapted them to your implementation. The existing coverage was a bit thin in this area, and the new tests give us more confidence that the parser switch works as expected. Hope this is okay. |
KristjanESPERANTO
approved these changes
Sep 16, 2026
khassel
approved these changes
Sep 16, 2026
This was referenced Sep 16, 2026
khassel
pushed a commit
that referenced
this pull request
Sep 17, 2026
…4271) While looking closer at newsfeed for #4212, #4267 and #4269, I felt `newsfeedfetcher.js` was doing too much: HTTP/parser stuff, HTML cleanup, and turning raw `feedparser` items into our item format, all in one file. This PR moves the HTML cleanup and item conversion into a new `feeditem.js`. `newsfeedfetcher.js` now only deals with HTTP/parser, feed-level TTL, and config validation for `allowedBasicHtmlTags`. This is just a refactor, no behavior change. Tests were split to match, plus I added one new test for the empty Atom `<summary>` case from #4212.
Merged
KristjanESPERANTO
added a commit
that referenced
this pull request
Oct 1, 2026
## Release Notes Thanks to: @ago1776, @alkank, @Antra, @Blackspirits, @deBasMan21, @flightlesstux, @i-xul, @jamalkamaladdin, @khassel, @KristjanESPERANTO, @MannXo, @pascalpfammatter, @rejas >⚠️ This release needs nodejs version >=22.22.2 <23 || >=24 [Compare to previous Release v2.37.0](v2.37.0...develop) ### [core] - Prepare Release 2.38.0 (#4285) - fix: let Electron select the Wayland display (#4268) - fix(http): improve access error messages (#4281) - fix: always redact client configuration (#4275) - refactor: migrate browser scripts to ESM (#4272) - refactor: convert animateCSS to ES module (#4266) - use filter instead of find to get all allowed secrets when multiple instances of a module are active (#4265) - refactor: convert notificationFx to ES module (#4263) - refactor: enforce function expression style (#4262) - fix: validate client IP behind trusted proxies (#4261) - prefer arrow over function (#4252) - refactor(utils): simplify configuration validation and error handling (#4240) - fix(server): validate request origins (#4234) - remove codeql warning (#4231) - refactor(socket): use direct ESM import in main (#4225) - refactor(socket): load Socket.IO client via ESM (#4224) - style: simplify Electron startup checks (#4213) - refactor: consolidate electron bootstrap into async function (#4210) - refactor(module): simplify and fix configMerge (#4203) - refactor: convert Translator to ES module (#4202) - docs: add CodeQL review steps and restructure after-release checklist (#4200) - refactor: centralize server port resolution (#4198) - refactor: use const instead of let for variable declarations (#4196) - refactor: replace Loader object with named exports (#4195) - set next release dev number - refactor(eslint): enforce prefer-arrow-callback rule (#4251) - refactor(http_fetcher): make dynamic URL handling explicit (#4282) - refactor: use explicit global config (#4233) - expand logic of hideConfigSecrets, add more tests (#4229) - refactor: make browser startup more explicit (#4214) ### [dependencies] - update dependencies (#4276) - update dependencies incl. electron to v44 (#4250) - chore: update eslint incl. plugins + review rules (#4236) - Bump actions/stale from 10 to 11 (#4215) - update dependencies (#4221) - Bump actions/setup-node from 6 to 7 (#4204) - chore: update dependencies (#4201) - Bump electron from 42.5.2 to 43.0.0 (#4192) ### [modules/alert] - Move alert translations into common translations (#4284) ### [modules/calendar] - Fixes issue 4243: Ensure while loop in calendar module does not get stuck when no entries (#4244) - fix(calendar): escape HTML in event title and location (#4260) - calendar: allow custom events to override symbol class (#4257) - Fix calendar crash when yearmatchgroup regex does not match (#4239) - fix(calendar): keep yearly events in DTSTART's month when BYMONTH is missing (#4222) - fix(calendar): correct multi-day slice day counts (#4232) - chore: update dependencies + adapt calendar tests (#4211) - fix(calendar): sliced multi-day events start at 00:00, not 23:59 (#4208) ### [modules/newsfeed] - newsfeed: don't use cors url in njk template (#4279) - refactor(newsfeed): extract feed item normalization into feeditem.js (#4271) - refactor(newsfeed): replace feedme lib with feedparser (#4269) - newsfeed: fix allowedBasicHtmlTags (#4258) - newsfeed: update checkArticleUrl (#4256) ### [modules/updatenotification] - feat(updatenotification): implement trusted module configuration for update commands (#4259) ### [modules/weather] - feat: add FMI weather provider (#4278) - feat(weather): enable CSS ordering for forecast and hourly columns (#4118) - fix(weather): respect initial load delay (#4254) - fix(weather): restrict provider loading to the providers directory (#4235) - refactor(weather): extract WeatherProvider base class (#4228) ### [testing] - ci: fail lint on warnings (#4230) - add test if install works for minimal node version (#4197) ### [translation] - feat(i18n): add Azerbaijani translation (#4283) - feat(i18n): complete Turkish translations (#4277) - Improve Portuguese translations (#4274) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kevin G. <crazylegstoo@gmail.com> Co-authored-by: veeck <gitkraken@veeck.de> Co-authored-by: Veeck <github@veeck.de> Co-authored-by: Karsten Hassel <hassel@gmx.de> Co-authored-by: Jboucly <33218155+jboucly@users.noreply.github.com> Co-authored-by: Jboucly <contact@jboucly.fr> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jarno <54169345+jarnoml@users.noreply.github.com> Co-authored-by: sam detweiler <sdetweil@gmail.com> Co-authored-by: Jordan Welch <JordanHWelch@gmail.com> Co-authored-by: Blackspirits <blackspirits@gmail.com> Co-authored-by: Samed Ozdemir <samed@xsor.io> Co-authored-by: in-voker <58696565+in-voker@users.noreply.github.com> Co-authored-by: Andrés Vanegas Jiménez <142350+angeldeejay@users.noreply.github.com> Co-authored-by: cgillinger <christian.gillinger@gmail.com> Co-authored-by: Sonny B <43247590+sonnyb9@users.noreply.github.com> Co-authored-by: sonnyb9 <sonnyb9@users.noreply.github.com> Co-authored-by: Morgan McBee <egeekial@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Mike Bishop <mbishop@evequefou.be> Co-authored-by: ago1776 <andi.goepfert@gmx.de> Co-authored-by: pascalpfammatter <pascal.pfammatter@mirific.ch> Co-authored-by: Pascal Pfammatter <304897782+pascalpfammatter@users.noreply.github.com> Co-authored-by: Anders Demant van der Weide <antra@antra.dk> Co-authored-by: Bas Buijsen <72604903+deBasMan21@users.noreply.github.com> Co-authored-by: Parman Mohammadalizadeh <prmma23@gmail.com> Co-authored-by: alkank <alkankizilca@gmail.com> Co-authored-by: Henkka <121262594+i-xul@users.noreply.github.com> Co-authored-by: Ercan Ermis <18646235+flightlesstux@users.noreply.github.com> Co-authored-by: Jamal Kamaladdinoglu <jamalkamaladdin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feedme.js seems to be dead, lets use something more maintained.
Could supersede #4267