Repository navigation
Forms list: wrap long titles instead of cutting them off on phones - #305
Merged
Merged
Conversation
The title link was inline-flex with w-fit, so a long title made the column as wide as the whole text. On a phone the end of it ran under the sticky action column and was cut off without any hint. The title now wraps at the column's minimum width on small screens and at 24rem from sm up, with overflow-wrap:anywhere for long words, so the whole title stays readable instead of being truncated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the forms list on a phone, a long form title ran under the sticky action column and was cut off without an ellipsis. The link was
inline-flex w-fit, so the title column grew as wide as the whole text.Fix
14rem(the column's minimum width) on small screens and at24remfromsmup.overflow-wrap:anywhereon the link and on the plain title, so a long word doesn't stretch the column again.Checked
pnpm --filter @msk-forms/web typecheck, eslint and prettier on the file.