Repository navigation
fix: accept the INSTALLMENT_SELECT next action type - #14
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthrough
ChangesInstallment selection next action
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No concrete failure in the installment-selection change is established; the supplied test covers deserialization of the new action type. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches✨ Simplify code
Comment |
Depends on MONEI/monei-openapi-schema#161. Regenerated from that branch (
build:local).Why: the API returns
nextAction.type = INSTALLMENT_SELECTfor card payments eligible for MONEI Flex.PaymentNextActionraisedApiValueErroron it, sopayments.get()and webhook parsing failed for those payments.Change: the enum value in
PaymentNextAction, plus a test that deserializes such a payment throughApiClient.deserialize(fails on master with the error above).Verification:
uv run pytest266 passed. Formatted with the pinneduv run black(25.1).build.shcalls the globalblack; a newer one also rewrote__init__.py,configuration.pyandrest.py(blank lines only). Those are left out.Summary by CodeRabbit