Repository navigation
Accept pathlib.Path record names in rdann - #626
Open
tompollard wants to merge 1 commit into
Open
tompollard wants to merge 1 commit into
tompollard wants to merge 1 commit into
Conversation
rdann built the annotation file name with record_name + "." + extension, which fails for a pathlib.Path. Convert record_name with os.fspath at the start, as rdrecord, rdsamp and rdheader already accept path-like objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rdannfails whenrecord_nameis apathlib.Path:The file name is built with
record_name + "." + extension.rdrecord,rdsampandrdheaderalready accept path-like objects, sordannnow convertsrecord_namewithos.fspathat the start, and the docstring saysstr or os.PathLike.This is the remaining part of #346, without the changes to how PhysioNet URLs are built.
Tests: reading
sample-data/100with aPathgives the same annotations as with a string (this fails onmain), and reading from a.wfdbarchive given as aPathworks too.