Repository navigation
Encode HTML tags in component initial data - #7
Merged
jissereitsma merged 1 commit intoSep 29, 2026
Merged
Conversation
Contributor
|
Thanks @rtgschepers - nice catch. I've added tests as well to check for this in the future. |
jissereitsma
added a commit
that referenced
this pull request
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this issue while working on a checkout that also had Amasty Store Pickup as a delivery method.
Problem: Component data is written as raw JSON inside , so any HTML in it is parsed into real DOM elements. This can cause the component's blockId to stay empty, and its updates fail with "Block name not specified".
Fix: Add JSON_HEX_TAG to the json_encode() in AddHtmlAttributesToComponentBlock::getJsData() so < and > are encoded and no elements are created.