Repository navigation
fix(studio): builder toolbar keeps "Open trace" at every width - #798
Merged
Merged
Conversation
Under the builder-toolbar container rules (920px and below, and 1180px and
below while an approval is pending) the run's trace link collapsed to
display: none, so from about 861 to 1200px - and at any width with a pending
approval - nothing in the wide bar linked to the trace. It now collapses to an
icon-only ExternalLink link (aria-label "Open trace", the title tooltip, same
href) instead.
So the link, the name and the decision genuinely fit at 1024 wide with an
approval pending, that short bar also drops the spacer, the breadcrumb's
"Agents" root, the status pill's text and the inline Approve/Reject labels
(each label stays the accessible name). The MOCK badge stays next to the
inline approval on a mock agent. The icon-only collapse rules are merged so
layout.css has no new clone groups.
Tests: RunStatus unit test for the icon/label/name; studio.spec checks the
link and MOCK badge are drawn unclipped at 1280 and 1024 with an approval
pending; docShots gains x-agents-toolbar-pending-{1280,1024,375}.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ooltips and focus ring Review round 1 for R2. In the 1180px-and-below approval tier the status pill now shows only its dot and the breadcrumb drops its "Agents" root, so the agent's name keeps its room at 1280 (previously "pendi..."). The live status pill carries its label as a title; Approve/Reject carry a tooltip (following the busy label) only in the toolbar's inline card. The icon-only trace link gets a surface-2 hover and an inset focus ring that the left group's clip cannot cut; the inline decision buttons are sized once (28px). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between ~861 and 1200px (and whenever an approval is pending) the builder had no link to the run's trace; collapse it to an icon-only 'Open trace' link instead of hiding it, and keep the MOCK badge beside the inline approval.
Ticket: R2 (Agent Forge Studio redesign, audit/forge-redesign/PLAN.md)
Changes
Verification: focused vitest,
tsc --noEmit, eslint, affected Playwright specs, light + dark screenshots reviewed; full suite and fallow run in CI.🤖 Generated with Claude Code