Repository navigation
hal: a stream of depth N holds N samples - #4678
Merged
Merged
Conversation
The ring keeps one slot free to tell full from empty, so a stream created with depth N took only N-1 samples. Allocate N+1 slots and keep reporting N as maxdepth. Drop the +1 that histobinstream and latencybinstream added for it, and fill the halmodule stream test to 10. Found by Bertho Stultiens in LinuxCNC#4674.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A HAL stream keeps one slot free to tell a full ring from an empty one, so a stream created with depth N held only N-1 samples. It now allocates N+1 slots, holds N, and still reports N as maxdepth.
histobinstream and latencybinstream added 1 to their depth to work around this; that is removed. tests/halmodule/stream asserted the old capacity and now fills a depth 10 stream with 10 samples.
@BsAtHome found this in #4674 and asked for it to be its own PR.