Repository navigation
release: prepare v1.3.2 stability fixes - #35
Merged
Merged
Conversation
审查者指南此版本增强了 Skills 和模型列表的渲染逻辑，以防止重复键崩溃；缓存长对话中的高开销计算；集中处理 Android 安全区域；新增经过清理的 Java/C++ 错误日志记录和安全的异步外部目录解析；并将 Android 版本更新至 v1.3.2，同时补充文档和测试。 安全外部目录解析的时序图sequenceDiagram
participant User
participant ProjectWorkspaceCoordinator
participant StoragePermissionService
participant AndroidStoragePermissionModule
participant Filesystem
User->>ProjectWorkspaceCoordinator: OpenExternalProject()
ProjectWorkspaceCoordinator->>StoragePermissionService: ResolveLocalDirectory(FileReference)
StoragePermissionService->>AndroidStoragePermissionModule: invoke resolveLocalDirectory
AndroidStoragePermissionModule->>Filesystem: resolve(volumeRoot, relative)
Filesystem-->>AndroidStoragePermissionModule: readable writable directory path
AndroidStoragePermissionModule-->>StoragePermissionService: path or permission-required error
StoragePermissionService-->>ProjectWorkspaceCoordinator: StorageDirectoryPathResult
ProjectWorkspaceCoordinator->>ProjectWorkspaceCoordinator: RegisterExternalProject(path, name)
经过清理的异常日志记录时序图sequenceDiagram
participant JavaRuntime
participant LineCodeLogger
participant CppRuntime
participant AppLogger
participant ErrorLogs
JavaRuntime->>LineCodeLogger: record(context, event, error)
LineCodeLogger->>ErrorLogs: write Java event and stack locations
CppRuntime->>AppLogger: LogAppError(event)
AppLogger->>ErrorLogs: write C++ event identifier
AppLogger-->>CppRuntime: recover if persistence fails
长对话渲染缓存流程图flowchart TD
A[Conversation recomposition] --> B[Read session messages and revision]
B --> C{Presentation cache still valid?}
C -- No --> D[BuildConversationPresentationMessages]
D --> E[Update presentation cache]
C -- Yes --> E
E --> F{Context snapshot cache still valid?}
F -- No --> G[SnapshotContext]
G --> H[Update context cache]
F -- Yes --> H
H --> I[Render chat, scrolling, taps, and streaming]
文件级变更
提示和命令与 Sourcery 交互
自定义使用体验访问你的控制面板以：
获取帮助Original review guide in EnglishReviewer's GuideThis release hardens Skills and model-list rendering against duplicate-key crashes, caches expensive long-conversation computations, centralizes Android safe-area handling, adds sanitized Java/C++ error logging and secure asynchronous external-directory resolution, and updates the Android release to v1.3.2 with documentation and tests. Sequence diagram for secure external directory resolutionsequenceDiagram
participant User
participant ProjectWorkspaceCoordinator
participant StoragePermissionService
participant AndroidStoragePermissionModule
participant Filesystem
User->>ProjectWorkspaceCoordinator: OpenExternalProject()
ProjectWorkspaceCoordinator->>StoragePermissionService: ResolveLocalDirectory(FileReference)
StoragePermissionService->>AndroidStoragePermissionModule: invoke resolveLocalDirectory
AndroidStoragePermissionModule->>Filesystem: resolve(volumeRoot, relative)
Filesystem-->>AndroidStoragePermissionModule: readable writable directory path
AndroidStoragePermissionModule-->>StoragePermissionService: path or permission-required error
StoragePermissionService-->>ProjectWorkspaceCoordinator: StorageDirectoryPathResult
ProjectWorkspaceCoordinator->>ProjectWorkspaceCoordinator: RegisterExternalProject(path, name)
Sequence diagram for sanitized exception loggingsequenceDiagram
participant JavaRuntime
participant LineCodeLogger
participant CppRuntime
participant AppLogger
participant ErrorLogs
JavaRuntime->>LineCodeLogger: record(context, event, error)
LineCodeLogger->>ErrorLogs: write Java event and stack locations
CppRuntime->>AppLogger: LogAppError(event)
AppLogger->>ErrorLogs: write C++ event identifier
AppLogger-->>CppRuntime: recover if persistence fails
Flow diagram for cached long-conversation renderingflowchart TD
A[Conversation recomposition] --> B[Read session messages and revision]
B --> C{Presentation cache still valid?}
C -- No --> D[BuildConversationPresentationMessages]
D --> E[Update presentation cache]
C -- Yes --> E
E --> F{Context snapshot cache still valid?}
F -- No --> G[SnapshotContext]
G --> H[Update context cache]
F -- Yes --> H
H --> I[Render chat, scrolling, taps, and streaming]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
嘿——我已经审阅了你的更改，整体看起来很棒！
Sourcery 评估
需要人工审阅。 Android 存储树桥接层可以将解析后的目录持久化到外部项目配置中，而不正确的 URI 到文件系统映射可能会导致后续项目操作指向错误的用户目录；即使回滚，也不会移除已经写入的注册信息或日志。其余的 UI、缓存和诊断更改通常会表现为可逆的运行时错误。
Original comment in English
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The Android storage-tree bridge can persist a resolved directory into the external-project configuration, and an incorrect URI-to-filesystem mapping could make later project operations target the wrong user directory; reverting would not remove registrations or logs already written. The remaining UI, caching, and diagnostic changes would normally be reversible runtime bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare v1.3.2 with fixes for the Skills store duplicate-key crash, model-list crash after saving, long-conversation UI stalls, exception logging, and status-bar overlap. No issue number was provided for this change.
User-visible behavior
update.md.Screenshots or recordings
Not captured. Emulator UI verification was skipped at the user's request for this release.
Validation
-j8(120/120).Commands and environment used:
Design and safety checklist
CLA — required
CLA Signature: @LangLang03
Sourcery 摘要
通过强化列表渲染和 Android 存储处理、提升长对话性能，并添加安全的错误日志记录和系统栏管理，为 v1.3.2 稳定版本发布做准备。
错误修复：
改进：
构建：
文档：
测试：
Original summary in English
Summary by Sourcery
Prepare the v1.3.2 stability release by hardening list rendering and Android storage handling, improving long-conversation performance, and adding safe error logging and system-bar management.
Bug Fixes:
Enhancements:
Build:
Documentation:
Tests: