Skip to content

Fix imshow set ax - #55

Merged
billbrod merged 5 commits into
mainfrom
fix_imshow_set_ax
Oct 26, 2026
Merged

billbrod merged 5 commits into
mainfrom
fix_imshow_set_ax

Conversation

@billbrod

Copy link
Copy Markdown
Member

Previous PRs (#54, #49 ) accidentally broke the ability to pass ax to imshow / animshow. This adds that ability back and raises a ValueError if someone passes ax to them and tries to display more than one image/video (previously, we were silently just displaying the first image/video, so better to be explicit).

Adds tests for that behavior.

Also adds a versionchanged tag to pyrshow explaining that is_complex is now gone (since this came up for plenoptic, plenoptic-org/plenoptic#502)

@billbrod billbrod mentioned this pull request Oct 22, 2026
6 tasks done
@billbrod
billbrod merged commit 2771b2e into main Oct 26, 2026
43 checks passed
@billbrod
billbrod deleted the fix_imshow_set_ax branch October 26, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant