Repository navigation
fix: allow idle Ctrl+C to exit completed worker views - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+C did nothing while viewing a completed worker, even when LeCode was idle and the input was empty. Only intercept Ctrl+C for the worker view while a root turn, plan loop, or worker is still running. Idle views can now use the existing clear-input and exit behavior.
Evidence
test_ctrl_c_completed_worker_view[False]failed because Ctrl+C did not exit the idle completed-worker view.After: The regression passes for both an idle app and an active root turn. The active root remains running when a completed worker is focused.
main(d827078):test_headless_timeout_kills_foreground_shellreturns exit 0 instead of the timeout code, andtest_sse_oauth_full_dance_and_token_reuseobserves two client registrations instead of one. These existing failures are outside this TUI change. Tests were run with the worktree root explicitly onPYTHONPATHbecause the local runner otherwise cannot import thetestspackage.Merge Danger
Door: two-way
Blast Radius: TUI
The change affects Ctrl+C routing while a worker is focused. Approval and question handling retain their existing priority. No provider configuration changes are included.