Skip to content

Why does the argument order of pyconvert_add_rule deviate from convention #363

Description

@LilithHafner

According to the Julia Docs, function arguments should be placed first because "Putting a function argument first permits the use of do blocks for passing multiline anonymous functions."

Is there a reason for not following this convention?
Would it be reasonable to support the conventional argument order in addition to the current argument order?
Can we switch fully to the conventional argument order and deprecate the current argument order / remove it in the next breaking release?

Activity

  1. cjdoris commented on Sep 21, 2023

    @cjdoris
    Member

    No particular reason. It started life as a non-API function. I'll consider this for v1 - the pyconvert machinery is going to be overhauled anyway.

  2. added this to the v1 milestone on Sep 21, 2023
  3. cjdoris commented on Sep 21, 2023

    @cjdoris
    Member

    Feel free to make a PR to add a version with the function-first order.

  4. removed this from the v1 milestone on May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions