Repository navigation
Throw PostgresInterfaceError for NUL bytes in protocol strings - #27
Merged
Merged
Conversation
writepart referred to Postgres.PostgresInterfaceError from inside module API, where the name Postgres is not bound, so SQL containing a NUL byte raised UndefVarError instead of the intended error. API already imports PostgresInterfaceError; use it directly. The check runs while the message is still buffered, so nothing is sent and the connection stays usable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
quinnj
referenced
this pull request
Oct 14, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL containing a NUL byte raised a confusing
UndefVarErrorinstead of the intendedPostgresInterfaceError:writepartinsrc/api/API.jlthrewPostgres.PostgresInterfaceError(...), but the namePostgresis not bound insidemodule API. The module already importsPostgresInterfaceError, so the fix drops the prefix. The startup-parameter variant had the same mistake; it is normally unreachable becauseConnectionrejects NUL bytes in its parameters first.The check runs while the message is still in a local buffer, so nothing reaches the server and the connection stays usable. That was already true; only the error type was wrong.
Tests:
PostgresInterfaceErrorand write nothing.DBInterface.execute(conn, "SELECT 1\0")throwsPostgresInterfaceErrorand the connection still answersSELECT 1.Validation:
main(2 ×UndefVarError) and passes with the fix.JET.report_package(Postgres; mode=:typo)reports exactly these two undefined references onmainand none with the fix, so there are no others in the package.🤖 Generated with Claude Code