Repository navigation
Fix loading on Julia 1.10: do not name an argument _ in methods with keyword arguments - #203
Merged
Merged
Conversation
Julia 1.10 rejects such methods with "syntax: all-underscore identifier used as rvalue", which made the package fail to load on the lowest supported Julia version. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaControl/ControlSystemIdentification.jl#202 added keyword arguments to the two
_default_freq_vectormethods forFRD, whose second argument is named_. Julia 1.10 rejects a method with an argument named_and keyword arguments:The package therefore fails to load on Julia 1.10, the lowest version allowed by the compat bound, and AutoMerge rejected the registration of v2.12.2 in JuliaRegistries/General#171095. This PR replaces
_by::Any. The definitiong(f, ::Any; kwargs...) = 1loads on Julia 1.10.12, whereasg(f, _; kwargs...) = 1reproduces the error.Host: demeter2 · Session: 974120bf-7fce-4326-8ff8-7a0911e29861 · Working directory: ~/.julia/dev/DyadControlSystems
🤖 Generated with Claude Code