Repository navigation
Direction and service skeletons - #2
Merged
Merged
Conversation
JSYoo5B
commented
Jul 2, 2026
| router.Get("/identity/", identityHandler.Discovery()) | ||
| router.Mount("/identity/v3", identityHandler.Router()) | ||
|
|
||
| router.Mount("/compute/v2.1", compute.NewRouter(cfg)) |
Owner
Author
There was a problem hiding this comment.
This mount pattern is the service URL contract used by the Keystone catalog. The other service mounts in this block follow the same idea, so this is the main place to verify route shape.
JSYoo5B
commented
Jul 2, 2026
| }) | ||
| } | ||
|
|
||
| func (h Handler) baseURL(r *http.Request) string { |
Owner
Author
There was a problem hiding this comment.
The version handlers use the same base URL fallback pattern across services. PublicURL wins when configured; otherwise the request host keeps local test servers and container ports usable without extra config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main Review Points
Verification