feat: support SQL Server table locking hints - #2673
Merged
manticore-projects merged 1 commit intoSep 21, 2026
Merged
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common SQL Server queries such as
SELECT * FROM jobs WITH (UPDLOCK, ROWLOCK)fail because SQLServerHints only recognizes INDEX and NOLOCK. This prevents parsing locking reads and work-queue queries that combine UPDLOCK, ROWLOCK and READPAST.Extend the existing SQLServerHints model with a typed, mutable list of 15 additional argument-free locking hints. Preserve their order within that list and retain the existing INDEX and nullable NOLOCK accessors/output. Reuse the same hint production for table sources and the shared aliased DML-target path, covering UPDATE and DELETE targets as well as SELECT, JOIN and CTE sources. Unknown hint names and argument forms are rejected rather than stored as arbitrary strings.
The scope is comma-separated locking hints inside
WITH (...). Parameterized access-path hints, additional INDEX argument forms and deprecated WITH/comma omissions are outside this change. Hint compatibility, isolation-level requirements and execution effects remain database checks.Syntax reference: Microsoft SQL Server table hints.
Validation:
checkpassed, including grammar ambiguity, formatting, Checkstyle, PMD, SpotBugs, coverage and 8015 JUnit tests (0 failures/errors, 25 skipped).