fix: parse compound expressions in array constructors - #2672
Merged
manticore-projects merged 1 commit intoSep 21, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid PostgreSQL input such as
ARRAY['a', (1 + 0)::text]fails because a short syntactic lookahead cannot see through the parenthesized arithmetic expression and chooses the nested-array fallback. A bare nested array beginning with a parenthesized element can also be mistaken for a function call.Parse every array element through a shared ArrayElement production, reusing the existing expression and range paths for the first and subsequent elements. Dispatch bare array constructors by their opening bracket and exclude that token from both the function-name probe and its cache eligibility guard. The existing ArrayConstructor AST and visitor APIs are unchanged.
Regression tests cover both expression-parser modes, first/middle/last positions, arithmetic and casts, CASE, scalar subqueries, NULL, row constructors, multidimensional arrays, AST mutation and visitor/table traversal. Existing bare/typed array, range and subscript forms retain coverage. Type compatibility and rectangular dimensions remain database checks.
Syntax reference: PostgreSQL array constructors.
Validation:
toString()output andStatementDeParseroutput. Five malformed inputs were rejected by the server; three additional type/dimension errors were rejected for all three output forms. Regressions include SELECT, INSERT, UPDATE and a JSON path-deletion expression using an array operand.checkpassed, including grammar ambiguity, formatting, Checkstyle, PMD, SpotBugs, coverage and 8006 JUnit tests (0 failures/errors, 25 skipped).