fix: preserve visitor context in expression deparsing - #2671
Merged
manticore-projects merged 1 commit intoSep 21, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpressionDeParser accepts a caller context but drops it at binary operators and several helper boundaries. A custom visitor processing
COALESCE(7, ABS(8 + 9)), for example, receives the context for 7 and null for 8 and 9. This makes context-dependent rewriting inconsistent within a single expression.Forward the supplied context through binary operators, expression lists/row constructors, function and analytic ORDER BY/LIMIT helpers, and parenthesized SELECT/CTE visitor handoffs. Add context-aware helper overloads while retaining the existing null-context entry points and legacy ORDER BY extension hooks.
Regression tests assert context identity through nested arithmetic, boolean, bitwise, CASE, IN, aggregate and window expressions, with unchanged default SQL output and legacy helper behavior. This is an expression traversal fix and does not change database syntax.
Validation:
checkpassed on Java 17, including grammar ambiguity, formatting, static analysis, coverage and the full test suite. JUnit XML totals: 7993 tests, 0 failures/errors, 25 skipped.