feat: add a structured SQL JSON predicate - #2669
Merged
manticore-projects merged 1 commit intoSep 21, 2026
Merged
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL accepts
expression IS [NOT] JSONwith optional VALUE/SCALAR/ARRAY/OBJECT and key-uniqueness clauses. These predicates currently fail to parse, including when used in WHERE and CHECK expressions.Add IsJsonExpression with a structured operand, JSON type and WITH/WITHOUT UNIQUE options. Preserve optional KEYS spelling and share rendering with ExpressionDeParser. The visitor default traverses the operand, preserving compatibility for existing visitor implementations, and TablesNamesFinder explicitly handles the new node.
Tests cover both expression-parser modes, negation, option combinations, boolean precedence, NULL, subqueries, visitor context, AST mutation, operand validation and malformed options. This models the predicate syntax; JSON contents are evaluated by the database, not by JSqlParser.
Syntax reference: PostgreSQL JSON predicates.
Validation:
checkpassed on Java 17, including grammar ambiguity, formatting, static analysis, coverage and the full test suite. JUnit XML totals: 8000 tests, 0 failures/errors, 25 skipped.toString()output andStatementDeParseroutput executed successfully with matching query results or resulting schema state. Invalid inputs were rejected by the server.