feat: model PostgreSQL LOCK targets and lock modes - #2668
Merged
manticore-projects merged 2 commits intoSep 21, 2026
Merged
manticore-projects merged 2 commits into
manticore-projects merged 2 commits into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL LOCK supports multiple targets, inheritance scopes, omitted TABLE/IN MODE clauses and three modes missing from the existing single-table model. This prevents parsing common statements such as
LOCK ONLY a, b * NOWAIT.Introduce structured lock targets with DEFAULT, ONLY and INCLUDING_DESCENDANTS scopes, and support all eight PostgreSQL lock modes. Factor target and mode parsing into separate productions and share statement rendering with StatementDeParser. TablesNamesFinder now visits every target. The existing table getters/setters remain a view of the first target, and existing Oracle SHARE UPDATE and WAIT forms retain regression coverage.
Tests cover all modes, multiple targets, optional clauses, quoted and qualified names, AST mutation, legacy constructors/accessors and conflicting or incomplete syntax. Oracle compatibility is covered by parser tests; Oracle server execution was not performed.
Syntax reference: PostgreSQL LOCK.
Validation:
checkpassed on Java 17, including grammar ambiguity, formatting, static analysis, coverage and the full test suite. JUnit XML totals: 7999 tests, 0 failures/errors, 25 skipped.toString()output andStatementDeParseroutput executed successfully with matching query results or resulting schema state. Invalid inputs were rejected by the server.