Repository navigation
feat(SDK-556): expose IterableConfig.identityResolution - #925
Merged
jferrao-itrbl merged 4 commits intoOct 19, 2026
Merged
jferrao-itrbl merged 4 commits into
jferrao-itrbl merged 4 commits into
Conversation
Add IterableIdentityResolution type and wire defaults through iOS/Android Serialization.
|
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (1)
🛟 Help
|
Name the case that sets only replayOnVisitorToKnown.
…6-identity-resolution Resolve IterableConfig, tests, and changelog conflicts by keeping UUA parity options with identity resolution.
jferrao-itrbl
marked this pull request as ready for review
October 14, 2026 10:22
rtlsilva
approved these changes
Oct 19, 2026
rtlsilva
left a comment
rtlsilva
left a comment
There was a problem hiding this comment.
Approving with one optional hardening finding. LGTM
Use optional chaining so null/undefined identityResolution defaults both flags to true instead of throwing during bridge serialization.
jferrao-itrbl
merged commit Oct 19, 2026
973b06f
into
feature/SDK-548-uua-feature-parity
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Expose
IterableConfig.identityResolutionandIterableIdentityResolutionfor UUA visitor replay and merge defaults (SDK-548 parity).🎟️ Jira Ticket: SDK-556
📖 Description
Adds the public
IterableIdentityResolutiontype andIterableConfig.identityResolution(default{ replayOnVisitorToKnown: true, mergeOnUnknownToKnown: true }).toDict()serializes the object withtruedefaults for omitted keys. iOS and AndroidSerializationmap the object to nativeIterableIdentityResolution. Per-call overrides onsetEmail/setUserIdremain out of scope. No TurboModule/codegen changes.🧪 How to test?
yarn typecheck && yarn test --coverageconfig.identityResolution = { replayOnVisitorToKnown: false, mergeOnUnknownToKnown: false }and confirm native config receives values (breakpoint in Serialization).🧾 Changelog
Unreleased entry added in
CHANGELOG.md.📹 Loom recording if applicable
N/A
🐞 Github Issues solved
N/A
📚 Docs PR if applicable
N/A