Skip to content

Normalize line endings to LF - #399

Open
antonwolfy wants to merge 1 commit into
masterfrom
normalize-line-endings
Open

antonwolfy wants to merge 1 commit into
masterfrom
normalize-line-endings

Conversation

@antonwolfy

Copy link
Copy Markdown
Collaborator

Description

Three tracked files were stored with CRLF line endings, while every other file in the repository uses LF:

  • conda-recipe-cf/conda_build_config.yaml
  • conda-recipe/conda_build_config.yaml
  • mkl_fft/_init_helper.py

The current .gitattributes only sets *.sh text eol=lf. This PR replaces it with the rule that dpnp uses, which also covers shell scripts:

* text=auto eol=lf

It stores all text files with LF and checks them out with LF, .bat files included, as in dpnp. The files above are renormalized with git add --renormalize .. Their contents don't change: git diff --ignore-cr-at-eol shows only .gitattributes. The same change is proposed in IntelPython/mkl_random#203 and IntelPython/dpctl#2396.

Verification

  • Tests: not run; no code changes.
  • Lint: pre-commit run --files on the changed files, Linux (WSL): all hooks passed.

Not verified

CI, including Windows checkouts.

Checklist

  • NumPy/SciPy FFT API compatibility preserved, or the break is intentional and called out above.
  • Behavior changes have tests in mkl_fft/tests/; bug fixes have a regression test.
  • CHANGELOG.md updated under ## [dev] with a [gh-NNN] link, or the change isn't user-visible.

Use the same .gitattributes as dpnp, so that text files are stored with
LF, and renormalize the files that were stored with CRLF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant