Repository navigation
Align conda-recipe-cf with the conda-forge feedstock - #253
Merged
Merged
Conversation
Build against glibc 2.17 on Linux and a macOS 11.0 deployment target, matching conda-forge's global pinning used by mkl-service-feedstock. Previously Linux used sysroot 2.28, and on macOS neither c_stdlib_version nor MACOSX_DEPLOYMENT_TARGET was set: the compiler targeted 10.9 while the newest macosx_deployment_target (26.0) stamped the package with __osx >=26.0. CI therefore could not catch regressions at the baseline conda-forge actually ships.
- Drop the unused `wheel` host dependency: the build scripts only run `pip install`, and meson-python builds the wheel itself - Drop the `pip >=25.0` floor, which is not an upstream requirement - Add `license_family: BSD`, as in mkl-service-feedstock - Remove a stale comment from bld.bat
antonwolfy
requested review from
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
October 13, 2026 12:25
jharlow-intel
approved these changes
Oct 15, 2026
jharlow-intel
left a comment
jharlow-intel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good! I compared it with the feedstock recipe and conda-forge's global pinning, and the sysroot and macOS deployment-target changes line up. The conda-forge workflow is green on all three platforms; the two red Windows Jenkins wheel jobs look like the flaky ones hitting other PRs today, not this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns
conda-recipe-cfwith mkl-service-feedstock, so the conda-forge CI job tests the package against the same baseline conda-forge ships.Stdlib baseline (
conda_build_config.yaml):2.28→2.17, the conda-forge default (conda-forgemklitself only requires__glibc >=2.17)c_stdlib_versionandMACOSX_DEPLOYMENT_TARGETto11.0. Neither was set, so the compiler targeted 10.9 while the newestmacosx_deployment_target(26.0) stamped the package with__osx >=26.0Tidy-ups (
meta.yaml,bld.bat):wheelhost dependency (the build scripts only runpip install, and meson-python builds the wheel itself) and thepip >=25.0floorlicense_family: BSD, as in the feedstockbld.bat