Repository navigation
Require NumPy 2.5.4 in median/nanmedian empty kept-dim tests - #3093
Merged
antonwolfy merged 1 commit intoOct 12, 2026
Merged
Conversation
NumPy 2.5.4 fixed the tuple-axis reduction of median and nanmedian when a kept dimension has size 0, so the tests now require it via with_requires and compare against NumPy unconditionally instead of using an inline version check with a hardcoded result shape.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
October 11, 2026 12:10
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
|
coverage: 78.667%. remained the same — use-numpy-floor-in-median-empty-kept-dim-tests into master |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev13=np2py314h8d9cdd5_3 ran successfully. |
vlad-perevezentsev
approved these changes
Oct 12, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Oct 12, 2026
This PR replaces the inline `numpy_version() >= "2.5.4"` check in
`TestMedian.test_empty_kept_dim` and `TestNanMedian.test_empty_kept_dim`
with the `@with_requires("numpy>=2.5.4")` marker. ac1791d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the inline
numpy_version() >= "2.5.4"check inTestMedian.test_empty_kept_dimandTestNanMedian.test_empty_kept_dimwith the@with_requires("numpy>=2.5.4")marker.