Skip to content

Sync third-party tests with recent upstream changes - #3092

Open
antonwolfy wants to merge 4 commits into
masterfrom
sync-cupy-kernel-arguments-tests
Open

antonwolfy wants to merge 4 commits into
masterfrom
sync-cupy-kernel-arguments-tests

Conversation

@antonwolfy

@antonwolfy antonwolfy commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

This PR syncs the third-party tests with recent upstream test changes. Only test files are changed.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

Add new tests for ufunc, reduction, elementwise kernel, copyto and
concatenate argument handling. Tests relying on unsupported features
(ufunc interface, CUDA array interface, ReductionKernel,
ElementwiseKernel) are skipped; expected error messages are adapted
to dpnp where only the wording differs.
Skip the argmax/argmin int32 overflow tests when the large array
cannot be allocated, rework the huge FFT allocation test to check
free memory upfront and clean up afterwards, and raise the timeout
for the jitify tests.
Add the thread_unsafe_on_windows helper and keep its use on
test_conversion_device_to_cpu commented out, since the thread_unsafe
marker is not registered in dpnp and the test is already skipped.
@antonwolfy antonwolfy added this to the 0.21.0 release milestone Oct 10, 2026
@antonwolfy antonwolfy self-assigned this Oct 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/3092/index.html

@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.21.0dev13=np2py314h8d9cdd5_6 ran successfully.
Passed: 1376
Failed: 0
Skipped: 6

@coveralls

coveralls commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 78.667%. remained the same — sync-cupy-kernel-arguments-tests into master

from __future__ import annotations

import ctypes
import sys

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_take_negative_index_at_int32_size_boundary in dpnp/tests/third_party/cupy/core_tests/test_ndarray_adv_indexing.py is missing
https://github.com/cupy/cupy/blob/main/tests/cupy_tests/core_tests/test_ndarray_adv_indexing.py#L725

]
jitify_markers = [
testing.slow(),
pytest.mark.timeout(1200), # Cold header initialization can take minutes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dpnp does not include pytest-timeout in its test dependencies
This should be commented for the future

]


def thread_unsafe_on_windows(func):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is not used
Does it make sense to comment it out?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would increase the diff, while keeping it has no drawback.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants