Repository navigation
fix: rename FAIL_INSURER_DENIED to FAIL_INSURANCE_COMPANY_DENIED - #13
Merged
Merged
Conversation
Core renames the case sub-state: in InsurUp "insurer" is the customer who buys the policy, and this sub-state is the insurance company declining. The policy received event's doc said "insurer" for the insurance company too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In InsurUp, "insurer" means the customer who buys the policy (sigorta ettiren). The case sub-state
FAIL_INSURER_DENIEDis the insurance company declining, so core renames it toFAIL_INSURANCE_COMPANY_DENIEDin InsurUp/core#1750. The numeric value 901 stays the same.What changes
FAIL_INSURER_DENIED→FAIL_INSURANCE_COMPANY_DENIED.onPolicyReceiveddoc: it said "insurer" for the insurance company; now it says insurance company.Breaking for consumers. Code that compares against the old value has to use the new one. No prod case has ever had this sub-state, so no stored data is affected.
Merge order
Merge after core#1750 is live, since it describes what core sends.
Checks
bun run typecheck,bun run lintandbun testare all clean (8 tests).🤖 Generated with Claude Code